-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: DynamoDB EventSourcedEndToEndSpec #1282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI seems to keep failing on dynamodb EventSourcedPubSubSpec, may just need even longer timeout.
* inspired by corresponding test for r2dbc * testing all projection types with real source provider
6b61fc5
to
a0b20f1
Compare
@@ -15,6 +15,7 @@ object TestConfig { | |||
.parseString(""" | |||
akka.loglevel = DEBUG | |||
akka.persistence.journal.plugin = "akka.persistence.dynamodb.journal" | |||
akka.persistence.snapshot-store.plugin = "akka.persistence.dynamodb.snapshot" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having the snapshot store enabled is causing some other tests to fail. We don't have this enabled for r2dbc either. I'll just remove it again for now. And can be enabled specifically for the end-to-end spec.
The end-to-end spec is also failing for me though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it's that we're not creating the snapshot table for tests. Will fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Green now.
Extended the r2dbc end-to-end spec in #1292. |
I can bring this back to the r2dbc.EventSourcedEndToEndSpec