Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: DynamoDB EventSourcedEndToEndSpec #1282

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

patriknw
Copy link
Member

@patriknw patriknw commented Dec 3, 2024

  • inspired by corresponding test for r2dbc
  • testing all projection types with real source provider

I can bring this back to the r2dbc.EventSourcedEndToEndSpec

@patriknw patriknw changed the title test: EventSourcedEndToEndSpec test: DynamoDB EventSourcedEndToEndSpec Dec 3, 2024
Copy link
Contributor

@pvlugter pvlugter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CI seems to keep failing on dynamodb EventSourcedPubSubSpec, may just need even longer timeout.

* inspired by corresponding test for r2dbc
* testing all projection types with real source provider
@pvlugter pvlugter force-pushed the wip-EventSourcedEndToEndSpec-patriknw branch from 6b61fc5 to a0b20f1 Compare January 9, 2025 23:43
@@ -15,6 +15,7 @@ object TestConfig {
.parseString("""
akka.loglevel = DEBUG
akka.persistence.journal.plugin = "akka.persistence.dynamodb.journal"
akka.persistence.snapshot-store.plugin = "akka.persistence.dynamodb.snapshot"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the snapshot store enabled is causing some other tests to fail. We don't have this enabled for r2dbc either. I'll just remove it again for now. And can be enabled specifically for the end-to-end spec.

The end-to-end spec is also failing for me though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it's that we're not creating the snapshot table for tests. Will fix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green now.

@pvlugter pvlugter merged commit c61ff47 into main Jan 10, 2025
22 checks passed
@pvlugter pvlugter deleted the wip-EventSourcedEndToEndSpec-patriknw branch January 10, 2025 01:33
@pvlugter
Copy link
Contributor

Extended the r2dbc end-to-end spec in #1292.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants